Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[decorators] Correctly insert _initialize(this) after super(). #8970

Merged
merged 3 commits into from Nov 7, 2018
Merged

[decorators] Correctly insert _initialize(this) after super(). #8970

merged 3 commits into from Nov 7, 2018

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 4, 2018 •
edited

Q                       A
Fixed Issues? Fixes #8931, fixes #8808
Patch: Bug Fix? y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This commit fixes to problem:

  1. After super(); statements, _initialize(this) was inserted without
    a trailing semicolon.
  2. (0, super()) causes an infinite recursion.

@nicolo-ribaudo
[decorators] Correctly insert _initialize(this) after super().
1e623dc 
This commit fixes to problem:
1) After `super();` statements, `_initialize(this)` was inserted without
   a trailing semicolon.
2) `(0, super())` causes an infinite recursion.
@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Decorators labels Nov 4, 2018
@babel-bot
Copy link
Collaborator

babel-bot commented Nov 4, 2018 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9323/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9322/

@danez danez merged commit b706e34 into babel:master Nov 7, 2018
@nicolo-ribaudo nicolo-ribaudo deleted the decorators-initialize-call-semicolon branch November 7, 2018 07:08
This was referenced Nov 14, 2018
Merged
Merged
Open
Open
@dependencies dependencies bot mentioned this pull request Dec 1, 2018
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@danez danez danez approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Decorators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing semicolon in constructor Decorator proposal plugin causes Stack overflow with super()
4 participants
@nicolo-ribaudo @babel-bot @existentialism @danez